[coreboot] [v2] r4241 - trunk/coreboot-v2/src/pc80

svn at coreboot.org svn at coreboot.org
Fri May 1 04:24:40 CEST 2009


Author: myles
Date: 2009-05-01 04:24:40 +0200 (Fri, 01 May 2009)
New Revision: 4241

Modified:
   trunk/coreboot-v2/src/pc80/keyboard.c
Log:
The semantics of the changed code are pretty simple and looking at
other parts of the same file shows that it is a common construct.

Remove the shadowed variable.

Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Peter Stuge <peter at stuge.se>

Modified: trunk/coreboot-v2/src/pc80/keyboard.c
===================================================================
--- trunk/coreboot-v2/src/pc80/keyboard.c	2009-04-30 22:45:41 UTC (rev 4240)
+++ trunk/coreboot-v2/src/pc80/keyboard.c	2009-05-01 02:24:40 UTC (rev 4241)
@@ -112,11 +112,10 @@
 		outb(0x60, 0x64);
 		if (!kbc_input_buffer_empty()) return;
 		outb(0x20, 0x60);	/* send cmd: enable keyboard and IRQ 1 */
-		u8 broken_resend = 10;
 		if ((inb(0x64) & 0x01)) {
 			regval = inb(0x60);
 		}
-		--broken_resend;
+		--resend;
 	} while (regval == 0xFE && resend > 0);
 
 	/* clean up any junk that might have been in the keyboard */





More information about the coreboot mailing list