[coreboot] [PATCH] flashrom: Fix SST25 status register routines

Peter Stuge peter at stuge.se
Wed May 6 15:52:11 CEST 2009

Carl-Daniel Hailfinger wrote:
> Improve SST25 status register routines:
> - Using a 4-bit index into an array with 8 elements leads to
> out-of-bounds accesses. That bug was introduced by a self-acked patch
> from someone. Use proper bit masking to fix this.

I think it's pointless to write "it was introduced by self-ack" at
all if you do not also write who it was. Either go all the way and
actually blame someone because you think it's a big deal or don't
bother because it's just about _one bit_. It takes more effort to
read the english text than to go with the patch.

My point; Some bugs warrant discussion, others maybe not as much.

> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Peter Stuge <peter at stuge.se>

More information about the coreboot mailing list