[coreboot] [PATCH] flashrom: Fix SST25 status register routines
peter at stuge.se
Wed May 6 16:33:23 CEST 2009
Carl-Daniel Hailfinger wrote:
> > I think it's pointless to write "it was introduced by self-ack" at
> > all if you do not also write who it was. Either go all the way and
> > actually blame someone because you think it's a big deal or don't
> > bother because it's just about _one bit_.
> It's one bit which can cause segfaults. I know who did it (svn
> blame helps), but I will NOT mention names in public. That would be
> bad style.
I don't think it's bad style at all! There is zero drama. This is
just a piece of software we're working on together. I make bugs too.
Either the bug is important enough to tease someone a little, or it's
not. The information is easily available from svn blame as you
mentioned so it's not like you would be letting out a secret.
> > My point; Some bugs warrant discussion, others maybe not as much.
> Anyway, I removed the part about the self-ack from the changelog.
Ok, but I think it would be fine for you to mention who caused it as
well, if you felt the need to.
And you could include the original rev. Or not.
Whatever is easiest and feels good. :)
> Thanks, r468.
More information about the coreboot