[coreboot] [v2] r4263 - trunk/coreboot-v2/util/cbfstool

svn at coreboot.org svn at coreboot.org
Fri May 8 22:07:00 CEST 2009


Author: myles
Date: 2009-05-08 22:07:00 +0200 (Fri, 08 May 2009)
New Revision: 4263

Modified:
   trunk/coreboot-v2/util/cbfstool/print.c
Log:
Trivial clean up of print usage and parameter checking.

Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Myles Watson <mylesgw at gmail.com>


Modified: trunk/coreboot-v2/util/cbfstool/print.c
===================================================================
--- trunk/coreboot-v2/util/cbfstool/print.c	2009-05-08 19:39:15 UTC (rev 4262)
+++ trunk/coreboot-v2/util/cbfstool/print.c	2009-05-08 20:07:00 UTC (rev 4263)
@@ -27,8 +27,11 @@
 
 int print_handler(struct rom *rom, int argc, char **argv)
 {
-	if (argc > 0 || argv[1] != NULL)
-		printf("print\t\t\t\tShow the contents of the ROM\n");
+	if ( argc > 0 ) {
+		ERROR("print %s? print takes no arguments.\n", argv[0]);
+		print_usage();
+		return -1;
+	}
 
 	printf("%s: %d kB, bootblocksize %d, romsize %d, offset 0x%x\n", rom->name, rom->size / 1024, 
 				ntohl(rom->header->bootblocksize), ntohl(rom->header->romsize), ntohl(rom->header->offset));





More information about the coreboot mailing list