[coreboot] [PATCH] flashrom: Abstraction for flash mapping/unmapping

Uwe Hermann uwe at hermann-uwe.de
Mon May 11 16:01:28 CEST 2009


On Mon, May 11, 2009 at 01:07:11PM +0200, Carl-Daniel Hailfinger wrote:
> >> With this patch, --programmer dummy works fine as non-root.
> >>
> >> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >>     
> 
> Thanks to Uwe for testing and reviewing.
> 
> New version:
> - Downgrade zero size mapping warning from stderr to printf_debug.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

with the small changes below.

 
> Index: flashrom-external_map_region/physmap.c
> ===================================================================
> --- flashrom-external_map_region/physmap.c	(Revision 491)
> +++ flashrom-external_map_region/physmap.c	(Arbeitskopie)
> @@ -69,12 +69,34 @@
>  
>  void physunmap(void *virt_addr, size_t len)
>  {
> +	if (len == 0) {
> +		printf_debug("Not unmapping zero size at %p\n",
> +			virt_addr);

virt_addr can be on the same line as printf_debug, no need for wrapping.


> Index: flashrom-external_map_region/flashrom.c
> ===================================================================
> --- flashrom-external_map_region/flashrom.c	(Revision 491)
> +++ flashrom-external_map_region/flashrom.c	(Arbeitskopie)
> @@ -40,6 +40,8 @@
>  	{
>  		.init		= internal_init,
>  		.shutdown	= internal_shutdown,
> +		.map_flash_region = physmap,
> +		.unmap_flash_region = physunmap,

Maybe realign the other entries with tabs, so they're vertically
aligned.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list