[coreboot] fix for cbfs error for longer file names

Kevin O'Connor kevin at koconnor.net
Tue May 12 01:48:13 CEST 2009

On Mon, May 11, 2009 at 10:08:47AM -0700, ron minnich wrote:
> On Mon, May 11, 2009 at 10:01 AM, Myles Watson <mylesgw at gmail.com> wrote:
> > I agree.  Let's do that first, since it would simplify this fix.  I'll
> > review and test.
> Let's see what other comments we get ... anyone out there see an issue
> with 32 byte character names? If you want, we can go with 40, which
> will size the struct up to a nice simple 64 bytes ...

Just my 2 cents, but I like the variable length file names.

BTW, you can simplify the existing coreboot code a bit if you add a
"char filename[0];" entry to 'struct cbfs_file' - as SeaBIOS does.


More information about the coreboot mailing list