[coreboot] [PATCH] flashrom: Differentiate SPI errors

Uwe Hermann uwe at hermann-uwe.de
Tue May 12 17:14:14 CEST 2009


On Mon, May 11, 2009 at 07:40:39PM +0200, Carl-Daniel Hailfinger wrote:
> There are various reasons why a SPI command can fail. Among others, I
> have seen the following problems:
> - The SPI opcode is not supported by the controller. ICH-style
> controllers exhibit this if SPI config is locked down.
> - The address in in a prohibited area. This can happen on ICH for any
> access (BBAR) and for writes in chipset write protected areas.
> - There is no SPI controller.
> 
> Introduce separate error codes for unsupported opcode and prohibited
> address.
> 
> Add the ability to adjust REMS and RES addresses to the minium supported
> read address with the help of spi_get_valid_read_addr(). That function
> needs to call SPI controller specific functions like reading BBAR on ICH.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list