[coreboot] [PATCH] flashrom: Add --list-supported-wiki, list known-good/-bad boards
c-d.hailfinger.devel.2006 at gmx.net
Tue May 12 18:31:15 CEST 2009
On 09.05.2009 04:07, Uwe Hermann wrote:
> See patch.
> The code may have some potential for simplification, but it basically
> works. I already used the output of the new -z option in the
> http://coreboot.org/Flashrom page, please check if there are errors in
> the output (or code).
> Add a --list-supported-wiki / -z option which outputs the currently
> supported flash chips (and their status), chipsets (plus status),
> and mainboards (plus status) to stdout.
> This allows for very easy pasting into the http://coreboot.org/Flashrom
> page, so we can keep that page up-to-date without much hassle.
> The list of boards is mostly new (known good ones which don't need
> write-enable code, and known-bad ones) and also lists URLs to the
> vendor's mainboard pages.
> These URLs are NOT printed in -L output per default, but they are
> if you use verbose mode, e.g. via -LV.
> They're also used in the --list-supported-wiki output for the wiki,
> of course.
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Thanks for this patch.
A few comments if I may:
Having the ability to get wikified output is definitely a huge
improvement over what we have today.
Please make sure the "... unknown SPI chip" variants are not listed.
Status: "Broken" ends up as "?".
IMHO the wiki output code uglifies quite a lot of files. Please stick it
into one common file called wikifier.c or something like that.
URLs in arrays feel weird. Having the URLs in wikifier.c as well would
make sure they are out of the way.
More information about the coreboot