[coreboot] [PATCH] flashrom: print hex in ich_spi_read_page

FENG Yu Ning fengyuning1984 at gmail.com
Wed May 13 02:24:01 CEST 2009


Carl-Daniel Hailfinger wrote:
> AFAIK %p already prints the 0x before the hex value, so buf=%p would be
> preferable.

Yes, I made a mistake. Maybe the C library on his system is reponsible
for the no "0x" output?

http://www.coreboot.org/pipermail/coreboot/2009-May/047736.html

> Other than that, I think the patch improves readability and is
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thank you.

> Do you have commit access or do you want me to commit with the small 0x
> change?

No, I don't have commit access. Please commit for me. Thanks.


yu ning




More information about the coreboot mailing list