[coreboot] [cbfstool] [PATCH] fix segfault when adding file that won't fit

Myles Watson mylesgw at gmail.com
Wed May 13 22:06:30 CEST 2009


This patch fixes a segfault when a file too large to fit is added to a rom
image.

Signed-off-by: Ward Vandewege <ward at gnu.org>

Index: fs.c
===================================================================
--- fs.c	(revision 4281)
+++ fs.c	(working copy)
@@ -99,7 +99,7 @@
 {
 	/* walk the rom and find an empty file with a base > base, and a
large enough size */
 	unsigned int offset = ntohl(rom->header->offset);
-	unsigned int ret = -1;
+	int ret = -1;

Good catch.

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles




More information about the coreboot mailing list