[coreboot] [PATCH] Table code cleanup

Myles Watson mylesgw at gmail.com
Thu May 14 22:54:35 CEST 2009


On Thu, May 14, 2009 at 12:48 PM, Myles Watson <mylesgw at gmail.com> wrote:
>
>
>> -----Original Message-----
>> From: Patrick Georgi [mailto:patrick at georgi-clan.de]
>> Sent: Thursday, May 14, 2009 11:13 AM
>> To: Myles Watson
>> Cc: coreboot
>> Subject: Re: [coreboot] [PATCH] Table code cleanup
>>
>> Am 14.05.2009 18:46, schrieb Myles Watson:
>> > On Thu, May 14, 2009 at 9:33 AM, Myles Watson<mylesgw at gmail.com>  wrote:
>> >> Sorry to be dense.  Could we do this in terms of which tables we want
>> in
>> >> each place?
>> >>
>> >> Page0 (low_table_start):
>> >> COREBOOT TABLE
>> >>
>> >> 0xf0000 (rom_table):
>> >> PIRQ
>> >> MPTABLE (with floating table)
>> >> ACPI bulk
>> >>
>> >> 0x7fff0000 (high_tables):
>> >> PIRQ
>> >> MPTABLE
>> >> ACPI bulk
>> >
>> > That was less than clear :)
>> In general, I agree with that table.
>> The constraints are:
>>
>> - MPTABLE must be two complete copies (because of Linux)
>>
>> - ACPI must be one copy (because there needs to be a single address for
>> some objects) with two RSDPs (see below).
>
> What about gdt?  It ends up in two places now, but never in fseg.  Why do we
> copy it to high_tables?

OK.  Try this one :)

I added a parameter to write_acpi_tables called rsdp2.  If it is
non-zero write an rsdp there.

I also assumed that one copy of gdt is enough and put it in low_tables.

abuild-tested and boot tested on Tyan s2892 and SimNOW.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tables.diff
Type: text/x-patch
Size: 20792 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090514/424fe85f/attachment.diff>


More information about the coreboot mailing list