[coreboot] [PATCH] flashrom: Handle WREN and EWSR failure gracefully on ICH/VIA SPI

Cristi Magherusan Cristi.Magherusan at net.utcluj.ro
Fri May 15 02:45:50 CEST 2009


On Thu, 2009-05-14 at 22:51 +0800, FENG Yu Ning wrote:
> Carl-Daniel Hailfinger wrote:
> > Until the ICH SPI driver can handle preopcodes as standalone opcodes, we
> > should handle such special opcode failure gracefully on ICH and
> > compatible chipsets.
> 
> Acked-by: FENG Yu Ning <fengyuning1984 at gmail.com>
> 
> iirc, Rudolf came to similar solution before, and I tried to hold it
> back. That might be a wrong decision.
> 
> I still don't like that much. However, I realize that personal taste
> is a bad reason to hold back a workaround for a long time. I don't
> want to make a wrong decision once more.
> 
> It seems not many are interested in it. Here is my ack.
> 
> yu ning
> 
Tested and works on real hardware - Asus M2V-MX-SE with SST
SST25VF032B" (4096 KB) SPI flash

Acked-by: Cristi Magherusan <cristi.magherusan at net.utcluj.ro>

Thanks!
Cristi

-- 
Cristi Măgherușan, System/Network Engineer
Technical University of Cluj-Napoca, Romania
http://cc.utcluj.ro  +40264 401247
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090515/5f492fc0/attachment.sig>


More information about the coreboot mailing list