[coreboot] [PATCH] flashrom: nic3com: add 16bit and 32bit chip reads/writes

Uwe Hermann uwe at hermann-uwe.de
Sat May 16 03:17:09 CEST 2009


On Sat, May 16, 2009 at 02:05:08AM +0200, Carl-Daniel Hailfinger wrote:
> On 16.05.2009 01:41, Carl-Daniel Hailfinger wrote:
> > Add 16 bit and 32 bit chip reads/writes to the nic3com driver. It
> > emulates those accesses by splitting them to 8 bit accesses.
> >
> > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> >   
> 
> New patch. Thanks to Uwe for the quick review on IRC.
> The emulation is not done in a generic function instead, which removes
> code from the nic3com driver.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Very nice, this eliminates/prevents useless dummy functions in all NIC code
files.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list