[coreboot] [v2] r4238 - in trunk/coreboot-v2/src/northbridge: amd/amdfam10 amd/gx1 amd/gx2 amd/lx intel/e7501 intel/e7520 intel/e7525 intel/i3100 intel/i440bx intel/i82810 intel/i82830 intel/i855gme intel/i855pm via/cn700 via/cx700 via/vt8601 via/vt8623

Kevin O'Connor kevin at koconnor.net
Sat May 16 15:08:37 CEST 2009


On Sat, May 16, 2009 at 02:07:34PM +0200, Patrick Georgi wrote:
> The northbridge code is already an improvement to before, where it was  
> in the mainboard code.
> I _think_, tolmk is only available in the northbridge (and mainboard  
> code called from there), so this code moved there instead of some truly  
> generic place.
>
> I'm very open to a more generic solution.

In the same file, right below the HIGH_TABLES stuff is:

		/* TODO: Hole needed? */
		ram_resource(dev, idx++, 0, 640);	/* First 640k */
		/* Leave a hole for VGA, 0xa0000 - 0xc0000 */
		ram_resource(dev, idx++, 768,
			     (tolmk - 768 - CONFIG_VIDEO_MB * 1024));

The high table stuff should just read through the "ram_resource" data
structures.  (It should find the highest 64KiB of ram that is less
than 4GiB.)  This can be done without any chipset or mainboard
specific code.

-Kevin




More information about the coreboot mailing list