[coreboot] [PATCH] flashrom: Use accessor functions for MMIO
uwe at hermann-uwe.de
Sun May 17 17:43:27 CEST 2009
On Sun, May 17, 2009 at 02:22:07AM +0200, Carl-Daniel Hailfinger wrote:
> Use accessor functions for MMIO. Some MMIO accesses used volatile,
> others didn't (and risked non-execution of side effects) and even with
> volatile, some accesses looked dubious.
> Since the MMIO accessor functions and the onboard flash accessor
> functions are functionally identical (but have different signatures),
> make the flash accessors wrappers for the MMIO accessors.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
I tested read, write, erase with this patch on a random board to make
sure nothing breaks.
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot