It might be worth inserting a comment here documenting why you're declaring this function inside vsprintf. > int vsprintf(char * buf, const char *fmt, va_list args) > { > + char *str_buf; > + void str_tx_byte(unsigned char byte) Acked-by: Myles Watson <mylesgw at gmail.com> Thanks, Myles