[coreboot] [v2] r4296 - trunk/util/getpir

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri May 29 15:02:59 CEST 2009


On 22.05.2009 20:17, svn at coreboot.org wrote:
> Author: uwe
> New Revision: 4296
>
> Make the getpir output look less crappy and add a license
> header template, as people keep forgetting them.
>
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
>   

Nack for 3 reasons:
1. It removes the notice where the data came from.
2. It adds a license to data which was not created by getpir.
3. It removes the URL pointing to the documentation.

> Modified: trunk/util/getpir/code_gen.c
> ===================================================================
> --- trunk/util/getpir/code_gen.c	2009-05-22 16:03:04 UTC (rev 4295)
> +++ trunk/util/getpir/code_gen.c	2009-05-22 18:17:06 UTC (rev 4296)
> @@ -3,21 +3,34 @@
>  #include "pirq_routing.h"
>  
>  static char *preamble[] = {
> -	"/* This file was generated by getpir.c, do not modify!\n",
> -	" * (but if you do, please run checkpir on it to verify)\n",
> +
> +	"/*\n",
> +	" * This file is part of the coreboot project.\n",
>  	" *\n",
> -	" * Contains the IRQ Routing Table dumped directly from your\n",
> -	" * memory, which BIOS sets up.\n",
> +	" * Copyright (C) 200x TODO <TODO at TODO>\n",
>  	" *\n",
> -	" * Documentation at: http://www.microsoft.com/whdc/archive/pciirq.mspx\n */\n\n",
> -	"#ifdef GETPIR\n",
> -	"#include \"pirq_routing.h\"\n",
> -	"#else\n"
> +	" * This program is free software; you can redistribute it and/or modify\n",
> +	" * it under the terms of the GNU General Public License as published by\n",
> +	" * the Free Software Foundation; either version 2 of the License, or\n",
> +	" * (at your option) any later version.\n",
>   

There are useful changes in this patch, so I won't simply revert it, but
please fix the points mentioned at the beginning of this mail.

Thanks.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list