[coreboot] [PATCH] flashrom: Make packagers happy

Peter Stuge peter at stuge.se
Fri May 29 16:51:06 CEST 2009


Carl-Daniel Hailfinger wrote:
> I think it was part of a trac page.

Oh - yeah, I guess it's possible to get tarballs out of trac.


> Anyway, a canonical download location for flashrom is the way to
> go.

Yes for sure! It would be nice to have a flashrom directory in
qa/snapshots/

The posthook will be simple with these Makefile changes.


> >> +# Note to packagers: Any tree exported with "make export" or "make tarball"
> >> +# will not require subversion.
> >
> > Do we need to say so? It think it is really intuitive that a snapshot
> > doesn't require svn.
> 
> Considering that packagers patch it out at the moment, I'd like to
> give them a hint that make export solves the issue.

Or we can provide tarballs. Everyone likes tarballs.



> Having the revision in releases+snapshots also allows us to quickly
> go to the correct revision without having to look it up or switch
> branches.

Sure.


> Plus, it kills two unnecessary commits per release.

Only unneccessary if they feel that way.


> > Well, it exports the working copy, which might have changes. At least
> > add -r to the export.

> > Again, it's not really the repo contents. With -r it is, then maybe
> > just say Created $filename because tar and the rev are part of the
> > filename?
> 
> OK. Should we use the (unmodified) repo contents or the directory
> contents?

svn export -r from a path gives both. See --help

If the unique atom in the export is the rev number, I think it makes
sense to try to avoid changes made after that rev.


> > Really in the README? Do we have INSTALL? Maybe it's time?
> 
> Good point. I'd postpone splitting to another patch, though.

I have no strong opinion.


//Peter




More information about the coreboot mailing list