[coreboot] [commit] r4939 - in trunk: . src src/arch/i386/boot src/arch/i386/include/arch/smp src/console src/cpu/emulation/qemu-x86 src/devices src/include/smp src/lib src/mainboard/emulation/qemu-x86 util/x86emu

[ron minnich]

On Thu, Nov 12, 2009 at 9:47 AM, Peter Stuge <peter at stuge.se> wrote:
> svn at coreboot.org wrote:
>> +++ trunk/src/include/smp/spinlock.h  2009-11-12 16:38:03 UTC (rev 4939)
> ..
>> -/* Most GCC versions have a nasty bug with empty initializers */
>> -#if (__GNUC__ > 2)
>
> Maybe add
>
> #if __GNUC__ < 3
> #error Sorry, at least gcc-3 is needed to build coreboot.
> #endif

Rather than sprinkle this kind of stuff all over the .h files we
should just tell people:
use the known-good crosstool

because we know that not even this test is sufficient

ron