[coreboot] [PATCH] The PC buzzer for TIM-5690.

[Uwe Hermann]

On Mon, Nov 23, 2009 at 12:01:26PM +0800, Bao, Zheng wrote:
> Should the spkr.c be in the folder sb600, or more public folders like
> pc80?

It looks generic to me, I'd put it into lib or src/arch/i386/lib as it
might be x86-specific.

I wrote a similar function for v3 a while ago, see attached file. Feel
free to use that one or merge the best parts of both.

svn co svn://coreboot.org/repository/coreboot-v3

File: arch/x86/speaker.c

However, in your file spkr.c (please rename to speaker.c for better
readability) there is no license header, so we cannot commit it.
Please add the usual GPL header and/or reuse my code (if it works,
don't remember how much of it was tested in v3). Thanks!


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: speaker.c
Type: text/x-csrc
Size: 3029 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091123/fb3abd9c/attachment.c>