[coreboot] [PATCH] device tree de-duplication

Myles Watson mylesgw at gmail.com
Tue Oct 6 22:56:17 CEST 2009

> I don't recommend doing this but it's done.
It's easily reverted.

> But until we kill newconfig, with this change, we've locked sconfig
> into supporting the newconfig tree grammar. If we fix or improve
> things for devicetree.cb we stand a change of breaking builds based on
> newconfig.
My opinion is that we have too many things up in the air.  When Patrick is
trying to figure out differences between Kconfig and newconfig, the last
thing he needs is a devicetree.cb that has been modified from the Config.lb
breaking things.
> So, in future, if we change the new tree grammar for some reason, we
> stand a chance of breaking abuild.
I thought the idea was to switch over to kbuildall before we made other
major changes.  Otherwise we have too many things to test.  For example the
s2881 that used to work.

> If we're going to do something like this change I'd prefer just
> removing Config.lb and Options.lb.
That seems one step more drastic than what I did.


More information about the coreboot mailing list