[coreboot] [PATCH] more Kconfig default fixes
stepan at coresystems.de
Tue Oct 13 16:20:02 CEST 2009
Myles Watson schrieb:
> > But we could check the position on the stack compared to the top of
> > the stack before running LZMA, right?
> That's hideously complicated. On AMD Fam10, each AP gets its own
> mini-stack at another location. The code for a stack checker is in v3
> and even for the no-SMP case it is really fragile. Add multiple stack
> sizes and multiple stack locations to it and the code will have to be
> marked "Do not touch even if you think you understand it".
> But yes, it can be done.
> I just meant compare against the top of all stacks (or the bottom of
> the heap.) Any checking is better than none.
> >>>> Those boards with STACK_SIZE being 0x2000 or 0x8000 are
> >>>> broken (and if they boot, they do by accident)
> >>> So since it's broken with Kconfig and newconfig, how can we
> decide what the
> >>> correct stack size should be?
0x8000 is the minimum for all boards. I think it should be the default.
More information about the coreboot