[coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

Uwe Hermann uwe at hermann-uwe.de
Wed Oct 21 21:16:00 CEST 2009

On Tue, Oct 20, 2009 at 11:37:02AM -0600, Myles Watson wrote:
> I like the idea of having Options that we use more available.
> DEBUG_SMI was the default.  Now it isn't.
> DEBUG_RAM_SETUP was the default for i440bx & vx800

True, but that's intentional. Just like the "use lzma" or "execute vga blob"
options these are now global, user-configurable (as opposed to per-board
in Options.lb in newconfig). The old per-board or per-chipset defaults don't
matter much, the user chooses if he/she wants the option.

I think these options are good candidates for filtering in the compare

> in the Kontron code,
> This never does anything, since 8 is SPEW.

Due to the recent LOGLEVEL changes, yes. We should do a repo-wide
fixing of any such occurences (there may be more of them). This is
unrelated to my patch though, the check is no longer correct with and
without the patch.

I'll post a followup-patch for this issue if nobody beats me to it.

> Right now I'd like to match newconfig and kill it as
> quickly as possible.

Sure, same here. I don't think this patch interferes with this effort

http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list