[coreboot] [patch] console code cleanup

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Oct 24 11:07:33 CEST 2009

On 24.10.2009 03:12, Stefan Reinauer wrote:
> re-order console output functions, add proper prototypes, 
> drop claim that our files were blatantly copied, because they have been
> rewritten a very long time ago.
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

I don't have a v2 tree handy right now, so I can't diff the result of
your patch with my v3 tree. How are your new code and the v3 code
related? Is this a rewrite of the existing v2 code or really just a
reodering? (diff generated a patch which is not exactly readable, but
that's not your fault.)

Looks good, though.

If you drop the unrelated ACPI hunk in src/config/Options.lb, this is
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


Developer quote of the week: 
"We are juggling too many chainsaws and flaming arrows and tigers."

More information about the coreboot mailing list