[coreboot] [PATCH] refactor SMI handler

Stefan Reinauer stepan at coresystems.de
Sun Oct 25 15:14:06 CET 2009

Peter Stuge wrote:
> Myles Watson wrote:
>>> No, but it would make sense... What's the right place for this?
>>> include/uart8250.h ?
>> maybe include/pc80/serial.h or include/pc80/uart8250.h?
> If either exists, use that. If neither exists I prefer the simpler
> serial.h.

include/uart8250.h is the only one that exists, hence my suggestion.

It occurs to me that we should have pc80/serial.c and lib/uart8250.c in the same directory. Maybe even the same file. They share a lot functionality.


More information about the coreboot mailing list