[coreboot] [PATCH] Remove all build/ prefixes in the build output
uwe at hermann-uwe.de
Wed Oct 28 18:13:05 CET 2009
On Wed, Oct 28, 2009 at 10:28:48AM -0600, Myles Watson wrote:
> Thanks for finding the build I missed.
> I'd prefer having "(This may take a while)" on the next line so that it
> doesn't wrap.
Hm? I don't understand what exactly wraps here? It should be one line
only, no wrapping.
> I prefer
> - print ' SCONFIG Output File:', os.path.basename(
> over custom splits and joins.
> + print ' SCONFIG ', join(outputfilename.split('/')[-5:], '/')
> Can we go back to os.path.basename? If so:
We could, but that's not consistent. This is the output with os.path.basename:
and this with the splits and joins:
As we do print the paths (relative to the build dir) for the other
files in the build output, I think we should do that here too.
> Acked-by: Myles Watson <mylesgw at gmail.com>
http://www.hermann-uwe.de | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot