[coreboot] [PATCH] more kconfig support

Uwe Hermann uwe at hermann-uwe.de
Tue Sep 29 12:01:11 CEST 2009


On Tue, Sep 29, 2009 at 01:30:04AM +0200, Stefan Reinauer wrote:
> Patrick Georgi wrote:
> >>> Index: src/southbridge/via/Makefile.inc
> >>> ===================================================================
> >>> --- src/southbridge/via/Makefile.inc	(Revision 4672)
> >>> +++ src/southbridge/via/Makefile.inc	(Arbeitskopie)
> >>> @@ -1,5 +1,4 @@
> >>> -#subdirs-y += k8t890
> >>> -#subdirs-y += vt8231
> >>> -#subdirs-y += vt8235
> >>> +subdirs-$(CONFIG_SOUTHBRIDGE_VIA_K8T890) += k8t890
> >>> +subdirs-$(CONFIG_SOUTHBRIDGE_VIA_VT8231) += vt8231
> >>> +subdirs-$(CONFIG_SOUTHBRIDGE_VIA_VT8235) += vt8235
> >>>  subdirs-$(CONFIG_SOUTHBRIDGE_VIA_VT8237R) += vt8237r
> >>>       
> >>> -#subdirs-y += vt82c686
> >>>       
> >> This will still be required later I guess (?).
> >>     
> > vt82c686 is a weird stub of southbridge support: I found no use of it,
> > and it seems to handle serial enable, only. My proposal? Unless it will
> > actually be used, get rid of it.
> >   
> 
> Acked-by: Stefan Reinauer <stepan at coresystems.de>

Please don't drop this. I have some boards with this southbridge, and
the code that's there looks OK (though unfinished, of course). I'll
put this on my TODO list and improve the SB code one of these days.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list