[coreboot] [PATCH] remove annoying noisy message

Stefan Reinauer stepan at coresystems.de
Fri Apr 2 18:16:37 CEST 2010

On 4/2/10 6:09 PM, ron minnich wrote:
> On Fri, Apr 2, 2010 at 9:04 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
>> See patch
> I'm mixed on this one, but at the same time, I bet there are few
> broken devices that return 0 as there were in the old days.
I wonder, what would we do with them if we knew..

Maybe we should only print the message if something else than 0xffffffff
is read? Would that be more appropriate?
0xffffffff is the expected read-back if there is no device, and I think
that case should not be reported as "bad id"

Like the attached one


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: good_ids_bad_ids.diff
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100402/8a72b355/attachment.ksh>

More information about the coreboot mailing list