[coreboot] [commit] r5359 - in trunk/src: . cpu/amd/model_10xxxcpu/amd/model_fxx cpu/amd/model_lx cpu/x86/mtrrinclude/cpu/x86 mainboard/amd/mahogany_fam10mainboard/amd/serengeti_cheetah mainboard/asus/a8n_...

Myles Watson mylesgw at gmail.com
Wed Apr 7 00:47:42 CEST 2010


> >> Now that we have Kconfig, I think this check can disappear.  Is there a
> way
> >> to un-define CONFIG_RAMTOP?

> > With RAMTOP being
> >
> > config RAMTOP
> > hex
> > default 0x200000
> >
> > it can't happen.
> >
> > But I didn't want to change the rough logical flow with self-acked code,
> > so I thought I better leave an error check too many in there ;-)

I agree that it's good to be careful.

I think it clutters this file to have so many checks.  I wonder if there
should be some central file for checking Kconfig variables.

Thanks,
Myles





More information about the coreboot mailing list