[coreboot] [PATCH] CAR on Intel P6 Series - Support for model_6bx

[Joseph Smith]

On Thu, 8 Apr 2010 16:02:09 -0600, "Myles Watson" <mylesgw at gmail.com>
wrote:
> 
> 
>> -----Original Message-----
>> From: Joseph Smith [mailto:joe at settoplinux.org]
>> Sent: Thursday, April 08, 2010 3:59 PM
>> To: Myles Watson
>> Cc: Stefan Reinauer; coreboot at coreboot.org
>> Subject: Re: [coreboot] [PATCH] CAR on Intel P6 Series - Support for
>> model_6bx
>>
>> >> > On 4/8/10 11:32 PM, Joseph Smith wrote:
>> >> >>>> Index: src/cpu/intel/model_6bx/Kconfig
>> >> >>>>
>> ===================================================================
>> >> >>>> --- src/cpu/intel/model_6bx/Kconfig        (revision 0)
>> >> >>>> +++ src/cpu/intel/model_6bx/Kconfig        (revision 0)
>> >> >>>> @@ -0,0 +1,3 @@
>> >> >>>> +config CPU_INTEL_CORE
>> >> >>>> +  bool
>> >> >>>> +  select SMP
>> >>
>> > This looks like it was copied directly from
> cpu/intel/model_6ex/Kconfig.
>> >
>> > You are redefining CPU_INTEL_CORE here.  This is probably where you
>> wanted
>> > to define CPU_INTEL_MODEL_6BX.
>> >
>> Ah ok thanks Myles.
>>
>> So there is not actually a:
>>
>> #define CPU_INTEL_MODEL_6BX blabla
>>
>> preprocessing directive anywhere. It just needs to be defined in
Kconfig.
> 
> That's right.  "config FOO" defines CONFIG_FOO.  "select FOO" just sets
it
> if it exists.  You can check in your .config file to make sure the
symbols
> you expect to be defined are showing up.
> 
Hmm, I wonder why this did not throw an error at me?

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org