[coreboot] [PATCH] clean up arch/i386

Stefan Reinauer stepan at coresystems.de
Tue Apr 20 11:42:14 CEST 2010

On the never ending quest to take complexity out of coreboot I suggest this:

- move src/arch/i386/smp/ioapic.c to src/arch/i386/lib/ioapic.c (has
nothing to do with SMP)
- move src/arch/i386/smp/mpspec.c to src/arch/i386/boot/mpspec.c (where
acpi, pirq and coreboot table generation lives)
- modify src/arch/i386/boot/Makefile.inc, src/arch/i386/lib/Makefile.inc
and src/arch/i386/smp/Makefile.inc accordingly
- src/arch/i386/smp is now empty. drop it.
- drop src/arch/i386/init/car.S (unused)

Not attached as patch, as the description and svn status is more

D src/arch/i386/smp
D src/arch/i386/smp/Makefile.inc
D src/arch/i386/smp/ioapic.c
D src/arch/i386/smp/mpspec.c
M src/arch/i386/boot/Makefile.inc
A + src/arch/i386/boot/mpspec.c
D src/arch/i386/init/car.S
M src/arch/i386/lib/Makefile.inc
A + src/arch/i386/lib/ioapic.c

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

We could also go a step further and
* join boot/ and lib/
* move boot/acpi* boot/mp* boot/pir* to arch/i386/tables/ or
* move boot/acpi* to arch/i386/acpi
* move src/arch/i386/lib/cpu.c to src/cpu/x86
* move src/arch/i386/lib/walkcbfs.S to src/arch/i386/init (where
bootblock_* is)
* move src/arch/i386/lib/printk_init.c to src/arch/i386/init
* move src/arch/i386/coreboot_ram.ld to src/arch/i386/lib (where
c_start.S is)

or generally join src/arch/i386/{boot,init,lib}

and maybe even src/{cpu,arch}.


coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

More information about the coreboot mailing list