[coreboot] [PATCH] RAMTOP fixes

Myles Watson mylesgw at gmail.com
Tue Apr 27 17:37:59 CEST 2010


>> Index: cbv2/src/cpu/x86/lapic/lapic_cpu_init.c
>> ===================================================================
>> --- cbv2.orig/src/cpu/x86/lapic/lapic_cpu_init.c
>> +++ cbv2/src/cpu/x86/lapic/lapic_cpu_init.c
>> @@ -246,19 +246,15 @@ int start_cpu(device_t cpu)
>>   index = ++last_cpu_index;
>>
>>   /* Find end of the new processors stack */
>> -#if (CONFIG_RAMTOP>0x100000) && (CONFIG_RAMBASE < 0x100000) &&
>> ((CONFIG_CONSOLE_VGA==1) || (CONFIG_PCI_ROM_RUN == 1))
>> +#if (CONFIG_RAMTOP>0x100000) && (CONFIG_RAMBASE < 0x100000)
>>   if(index<1) { // only keep bsp on low
>> - stack_end = ((unsigned long)_estack) - (CONFIG_STACK_SIZE*index) -
>> sizeof(struct cpu_info);
>> + stack_end = ((unsigned long)_estack) - sizeof(struct cpu_info);
>>
>>
>> Does this not break for multiple CPUs?
> No.  All of this logic was for putting the AP stacks above 1M when the
> main stack was below 1M and you didn't want it to run into the VGA
> area.  Do we have any multiprocessors that still use

Sorry, I got interrupted.  It was supposed to be:
Do we have any multiprocessors that still use CONFIG_RAMBASE < 1M?

Thanks,
Myles




More information about the coreboot mailing list