[coreboot] [commit] r5518 - trunk/src/superio/winbond/w83627hf

repository service svn at coreboot.org
Fri Apr 30 22:30:47 CEST 2010


Author: stepan
Date: Fri Apr 30 22:30:47 2010
New Revision: 5518
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5518

Log:
Remove some warnings. For code that is called from the mainboard romstage.c
files using prototypes is the way to go I think. It would make our life a lot
easier should we ever decide to move (some mainboards) over to not #include
all those .c files in romstage.c anymore.

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Modified:
   trunk/src/superio/winbond/w83627hf/w83627hf.h
   trunk/src/superio/winbond/w83627hf/w83627hf_early_init.c

Modified: trunk/src/superio/winbond/w83627hf/w83627hf.h
==============================================================================
--- trunk/src/superio/winbond/w83627hf/w83627hf.h	Fri Apr 30 22:28:35 2010	(r5517)
+++ trunk/src/superio/winbond/w83627hf/w83627hf.h	Fri Apr 30 22:30:47 2010	(r5518)
@@ -109,3 +109,9 @@
 #define W83627HF_HAP1		0x14
 #define W83627HF_XSCNF		0x15
 #define W83627HF_XWBCNF		0x16
+
+#if defined(__PRE_RAM__) && !defined(__ROMCC__)
+void w83627hf_disable_dev(device_t dev);
+void w83627hf_enable_dev(device_t dev, unsigned iobase);
+#endif
+

Modified: trunk/src/superio/winbond/w83627hf/w83627hf_early_init.c
==============================================================================
--- trunk/src/superio/winbond/w83627hf/w83627hf_early_init.c	Fri Apr 30 22:28:35 2010	(r5517)
+++ trunk/src/superio/winbond/w83627hf/w83627hf_early_init.c	Fri Apr 30 22:30:47 2010	(r5518)
@@ -23,13 +23,13 @@
 #include <arch/romcc_io.h>
 #include "w83627hf.h"
 
-static void w83627hf_disable_dev(device_t dev)
+void w83627hf_disable_dev(device_t dev)
 {
 	pnp_set_logical_device(dev);
 	pnp_set_enable(dev, 0);
 }
 
-static void w83627hf_enable_dev(device_t dev, unsigned iobase)
+void w83627hf_enable_dev(device_t dev, unsigned iobase)
 {
 	pnp_set_logical_device(dev);
 	pnp_set_enable(dev, 0);




More information about the coreboot mailing list