[coreboot] [PATCH] Gigabyte MA785GMT support

Stefan Reinauer stefan.reinauer at coresystems.de
Sun Aug 15 13:51:50 CEST 2010


 On 8/13/10 9:50 AM, Qing Pei Wang wrote:
> hi,
>   the attach file added the support of Gigabyte MA785GMT mainboard.
> the details of the hardware configuration can be found at
> http://www.gigabyte.com/products/product-page.aspx?pid=3478
> a breif configuration is:
> 1. CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD
> Athlon™ II processor
> 2. North Bridge: AMD 785G
> 3. South Bridge: AMD SB710
> 4: Super IO : ITE8718F
>
> The mainboard has two bios flashchip. Coreboot ROM should be flashed
> into the M_BIOS(which means main bios).
> signed-off-by Wang Qing Pei <wangqingpei at gmail.com
> <mailto:wangqingpei at gmail.com>>

Hi Qing Pei!

Thanks for this patch! It's great to have more boards in the tree.

> --- src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)
> +++ src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)
>
..
> +#ifndef MB_SYSCONF_H
> +
> +#define MB_SYSCONF_H
> +
> +struct mb_sysconf_t {
> +       u8 bus_isa;
> +       u8 bus_8132_0;
> +       u8 bus_8132_1;
> +       u8 bus_8132_2;
> +       u8 bus_8111_0;
> +       u8 bus_8111_1;
> +       u8 bus_8132a[31][3];
> +       u8 bus_8151[31][2];
> +
> +       u32 apicid_8111;
> +       u32 apicid_8132_1;
> +       u32 apicid_8132_2;
> +       u32 apicid_8132a[31][2];
> +       u32 sbdn3;
> +       u32 sbdn3a[31];
> +       u32 sbdn5[31];
> +       u32 bus_type[256];
> +};
> +
> +#endif
Can you check if this file is really needed?

I would expect that anything that references AMD8132, AMD8111 and
AMD8151 is not needed on an AMD785/SB710 board?

Also, a lot of files in the patch are exact copies of the AMD Tilapia
board. I counted 15 files where the only change from Tilapia is the
following:

> @@ -1,7 +1,7 @@
>  /*
>   * This file is part of the coreboot project.
> - * Copyright (C) 2010 Advanced Micro Devices, Inc.
> + * Copyright (C) 2010 Wang Qing Pei <wangqingpei at gmail.com>
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by

Some more change the name from AMD Tilapia to Gigabyte GA785GMT in
addition to that.

Those files should keep the AMD copyright in there I believe. The ones
that you didn't change should not have your copyright added.

I think with above issues adressed we could commit this patch.

Thanks,

Stefan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100815/9a59e076/attachment.html>


More information about the coreboot mailing list