[coreboot] mainboard.c: init() still being called?
mylesgw at gmail.com
Mon Aug 16 17:54:15 CEST 2010
> Myles Watson wrote:
> > The attached patch calls init() again. It makes it match the comments
> > Signed-off-by: Myles Watson <mylesgw at gmail.com>
> Acked-by: Peter Stuge <peter at stuge.se>
> > It makes sense to use values in the device tree to parameterize
> > device code for specific mainboards, but I don't see the point of
> > parameterizing mainboard-specific code from the device tree.
> It's no secret that I'd like coreboot to have zero mainboard-specific
> code, and allow parameters to be used to completely describe a board.
In that case, are you sure you want to ack it? Right now there are very few
boards that have mainboard init functions ( < 20). I think now is the time
to migrate away from it if it's a bad idea.
I don't think it would take very long to help Jens change the code so that
the initialization that was done by the mainboard code gets done in the
cs5536 code where it belongs.
More information about the coreboot