[coreboot] mainboard.c: init() still being called?
stefan.reinauer at coresystems.de
Mon Aug 16 18:11:58 CEST 2010
On 8/16/10 5:11 PM, Myles Watson wrote:
> I think that the value that was left out of devicetree.cb should move
> to the mainboard init() or into the device that's being configured
> (cs5536.) It makes sense to use values in the device tree to
> parameterize device code for specific mainboards, but I don't see the
> point of parameterizing mainboard-specific code from the device tree.
> Index: src/devices/device.c
> --- src/devices/device.c (revision 5692)
> +++ src/devices/device.c (working copy)
> @@ -1104,6 +1104,9 @@
> printk(BIOS_INFO, "Initializing devices...\n");
> + /* First call the mainboard init. */
> + init_dev(&dev_root);
> /* now initialize everything. */
> for (link = dev_root.link_list; link; link = link->next)
Acked-by: Stefan Reinauer <stepan at coresystems.de>
Thanks for fixing coreboot. mainboard specific setup code is critical
for many boards.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot