[coreboot] [commit] r5722 - trunk/payloads/libpayload/drivers/video

[repository service]

Author: oxygene
Date: Wed Aug 18 23:23:27 2010
New Revision: 5722
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5722

Log:
libpayload: fix garbage on screen with Geode-LX VGA

Clear initial garbage in VGA memory and fix scroll_up, which scrolled 1 scanline
instead of 1 text line by mistake.

Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
Acked-by: Patrick Georgi <patrick at georgi-clan.de>

Modified:
   trunk/payloads/libpayload/drivers/video/geodelx.c

Modified: trunk/payloads/libpayload/drivers/video/geodelx.c
==============================================================================
--- trunk/payloads/libpayload/drivers/video/geodelx.c	Wed Aug 18 03:55:11 2010	(r5721)
+++ trunk/payloads/libpayload/drivers/video/geodelx.c	Wed Aug 18 23:23:27 2010	(r5722)
@@ -206,7 +206,7 @@
 static void geodelx_scroll_up(void)
 {
 	unsigned char *dst = FB;
-	unsigned char *src = FB + vga_mode.hactive;
+	unsigned char *src = FB + FONT_HEIGHT * vga_mode.hactive;
 	int y;
 
 	for(y = 0; y < vga_mode.vactive - FONT_HEIGHT; y++) {
@@ -216,8 +216,6 @@
 		src += vga_mode.hactive;
 	}
 
-	dst = FB + (vga_mode.vactive - FONT_HEIGHT) * vga_mode.hactive;
-
 	for(; y < vga_mode.vactive; y++) {
 		memset(dst, 0, vga_mode.hactive);
 		dst += vga_mode.hactive;
@@ -280,6 +278,8 @@
 		geodelx_set_palette(i, vga_colors[i]);
 	}
 
+	geodelx_clear();
+
 	return 0;
 }