[coreboot] Kconfig: convert dependency lists into HAVE_x properties
Jens Rottmann
JRottmann at LiPPERTEmbedded.de
Fri Aug 27 11:32:04 CEST 2010
Patrick Georgi wrote:
> 1. we started with HAVE_HIGH_TABLES default to no, to enable by the
> boards that support it
> 2. then moved to default to yes, to be disabled by the boards that
> have issues with that (r5160)
>
> At some point, HAVE_HIGH_TABLES should be removed altogether. Maybe
> that should be now.
Converted mail into patch.
Signed-off-by: Jens Rottmann <JRottmann at LiPPERTEmbedded.de>
---
Hi Patrick,
if I understand you correctly, WRITE_HIGH_TABLES should always be enabled,
except for 3 boards. Is this patch what you had in mind?
BTW: did you answer to my mail directly? Because I saw your and many
other responses only in the mailing list, but our mailserver admin
denies anything getting lost.
Cheers,
Jens
--- src/Kconfig (rev 5744)
+++ src/Kconfig (working copy)
@@ -261,16 +261,6 @@
asus/m2v-mx_se
supermicro/h8dme
-config HAVE_HIGH_TABLES
- bool
- default y
- help
- This variable specifies whether a given northbridge has high table
- support.
- It is set in northbridge/*/Kconfig.
- Whether or not the high tables are actually written by coreboot is
- configurable by the user via WRITE_HIGH_TABLES.
-
config HAVE_ACPI_TABLES
bool
help
@@ -310,16 +300,15 @@
bool
default HAVE_PIRQ_TABLE
-config WRITE_HIGH_TABLES
- bool
- default HAVE_HIGH_TABLES
-
menu "System tables"
+config BUGGY_HIGH_TABLES
+ def_bool n
+
config WRITE_HIGH_TABLES
bool "Write 'high' tables to avoid being overwritten in F segment"
- depends on HAVE_HIGH_TABLES
default y
+ depends on !BUGGY_HIGH_TABLES
config MULTIBOOT
bool "Generate Multiboot tables (for GRUB2)"
--- src/mainboard/amd/dbm690t/Kconfig (rev 5744)
+++ src/mainboard/amd/dbm690t/Kconfig (working copy)
@@ -8,6 +8,7 @@
select SOUTHBRIDGE_AMD_SB600
select SUPERIO_ITE_IT8712F
select BOARD_HAS_FADT
+ select BUGGY_HIGH_TABLES
select GENERATE_ACPI_TABLES
select GENERATE_MP_TABLE
select GENERATE_PIRQ_TABLE
@@ -24,11 +25,6 @@
default amd/dbm690t
depends on BOARD_AMD_DBM690T
-config HAVE_HIGH_TABLES
- bool
- default n
- depends on BOARD_AMD_DBM690T
-
# This is a temporary fix, and should be removed when the race condition for
# building option_table.h is fixed.
config WARNINGS_ARE_ERRORS
--- src/mainboard/amd/mahogany/Kconfig (rev 5744)
+++ src/mainboard/amd/mahogany/Kconfig (working copy)
@@ -8,6 +8,7 @@
select SOUTHBRIDGE_AMD_SB700
select SUPERIO_ITE_IT8718F
select BOARD_HAS_FADT
+ select BUGGY_HIGH_TABLES
select GENERATE_ACPI_TABLES
select GENERATE_MP_TABLE
select GENERATE_PIRQ_TABLE
@@ -26,11 +27,6 @@
default amd/mahogany
depends on BOARD_AMD_MAHOGANY
-config HAVE_HIGH_TABLES
- bool
- default n
- depends on BOARD_AMD_MAHOGANY
-
config DCACHE_RAM_BASE
hex
default 0xc8000
--- src/mainboard/asrock/939a785gmh/Kconfig (rev 5744)
+++ src/mainboard/asrock/939a785gmh/Kconfig (working copy)
@@ -9,6 +9,7 @@
select SOUTHBRIDGE_AMD_SB700
select SUPERIO_WINBOND_W83627DHG
select BOARD_HAS_FADT
+ select BUGGY_HIGH_TABLES
select GENERATE_ACPI_TABLES
select GENERATE_MP_TABLE
select GENERATE_PIRQ_TABLE
@@ -27,11 +28,6 @@
default asrock/939a785gmh
depends on BOARD_ASROCK_939A785GMH
-config HAVE_HIGH_TABLES
- bool
- default n
- depends on BOARD_ASROCK_939A785GMH
-
config DCACHE_RAM_BASE
hex
default 0xc8000
--- src/northbridge/amd/amdfam10/Kconfig (rev 5744)
+++ src/northbridge/amd/amdfam10/Kconfig (working copy)
@@ -21,7 +21,6 @@
bool
select HAVE_DEBUG_RAM_SETUP
select HAVE_DEBUG_SMBUS
- select HAVE_HIGH_TABLES
select HYPERTRANSPORT_PLUGIN_SUPPORT
select NORTHBRIDGE_AMD_AMDFAM10_ROOT_COMPLEX
--- src/northbridge/amd/amdk8/Kconfig (rev 5744)
+++ src/northbridge/amd/amdk8/Kconfig (working copy)
@@ -21,7 +21,6 @@
bool
select HAVE_DEBUG_RAM_SETUP
select HAVE_DEBUG_SMBUS
- select HAVE_HIGH_TABLES
select HYPERTRANSPORT_PLUGIN_SUPPORT
config AGP_APERTURE_SIZE
--- src/northbridge/amd/lx/Kconfig (rev 5744)
+++ src/northbridge/amd/lx/Kconfig (working copy)
@@ -1,6 +1,5 @@
config NORTHBRIDGE_AMD_LX
bool
- select HAVE_HIGH_TABLES
select GEODE_VSA
config VIDEO_MB
--- src/northbridge/intel/e7501/Kconfig (rev 5744)
+++ src/northbridge/intel/e7501/Kconfig (working copy)
@@ -1,5 +1,3 @@
config NORTHBRIDGE_INTEL_E7501
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/e7520/Kconfig (rev 5744)
+++ src/northbridge/intel/e7520/Kconfig (working copy)
@@ -1,4 +1,2 @@
config NORTHBRIDGE_INTEL_E7520
bool
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/e7525/Kconfig (rev 5744)
+++ src/northbridge/intel/e7525/Kconfig (working copy)
@@ -1,4 +1,2 @@
config NORTHBRIDGE_INTEL_E7525
bool
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/i3100/Kconfig (rev 5744)
+++ src/northbridge/intel/i3100/Kconfig (working copy)
@@ -1,4 +1,2 @@
config NORTHBRIDGE_INTEL_I3100
bool
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/i440bx/Kconfig (rev 5744)
+++ src/northbridge/intel/i440bx/Kconfig (working copy)
@@ -20,7 +20,6 @@
config NORTHBRIDGE_INTEL_I440BX
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
config SDRAMPWR_4DIMM
bool
--- src/northbridge/intel/i440lx/Kconfig (rev 5744)
+++ src/northbridge/intel/i440lx/Kconfig (working copy)
@@ -19,5 +19,3 @@
config NORTHBRIDGE_INTEL_I440LX
bool
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/i82810/Kconfig (rev 5744)
+++ src/northbridge/intel/i82810/Kconfig (working copy)
@@ -20,7 +20,6 @@
config NORTHBRIDGE_INTEL_I82810
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
choice
prompt "Onboard graphics"
--- src/northbridge/intel/i82830/Kconfig (rev 5744)
+++ src/northbridge/intel/i82830/Kconfig (working copy)
@@ -1,7 +1,6 @@
config NORTHBRIDGE_INTEL_I82830
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
choice
prompt "Onboard graphics"
--- src/northbridge/intel/i855/Kconfig (rev 5744)
+++ src/northbridge/intel/i855/Kconfig (working copy)
@@ -1,4 +1,2 @@
config NORTHBRIDGE_INTEL_I855
bool
- select HAVE_HIGH_TABLES
-
--- src/northbridge/intel/i945/Kconfig (rev 5744)
+++ src/northbridge/intel/i945/Kconfig (working copy)
@@ -20,7 +20,6 @@
config NORTHBRIDGE_INTEL_I945
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
config FALLBACK_VGA_BIOS_ID
string
--- src/northbridge/via/cn700/Kconfig (rev 5744)
+++ src/northbridge/via/cn700/Kconfig (working copy)
@@ -1,7 +1,6 @@
config NORTHBRIDGE_VIA_CN700
bool
select HAVE_DEBUG_RAM_SETUP
- select HAVE_HIGH_TABLES
config FALLBACK_SIZE
int
--- src/northbridge/via/cx700/Kconfig (rev 5744)
+++ src/northbridge/via/cx700/Kconfig (working copy)
@@ -2,7 +2,6 @@
bool
select HAVE_DEBUG_RAM_SETUP
select HAVE_DEBUG_SMBUS
- select HAVE_HIGH_TABLES
select HAVE_HARD_RESET
select IOAPIC
select SMP
--- src/northbridge/via/vt8601/Kconfig (rev 5744)
+++ src/northbridge/via/vt8601/Kconfig (working copy)
@@ -1,6 +1,5 @@
config NORTHBRIDGE_VIA_VT8601
bool
- select HAVE_HIGH_TABLES
config FALLBACK_SIZE
int
--- src/northbridge/via/vt8623/Kconfig (rev 5744)
+++ src/northbridge/via/vt8623/Kconfig (working copy)
@@ -1,6 +1,5 @@
config NORTHBRIDGE_VIA_VT8623
bool
- select HAVE_HIGH_TABLES
config FALLBACK_SIZE
int
_
More information about the coreboot
mailing list