[coreboot] [PATCH]Allow components to add files to CBFS
stepan at coreboot.org
Wed Dec 15 19:50:14 CET 2010
* Patrick Georgi <patrick at georgi-clan.de> [101215 12:51]:
> We have a couple of chipsets in the tree that require external data in CBFS,
> sometimes with placement requirements (eg. for embedded controllers), and
> there will be more of that kind to come.
> Right now, we're adding Kconfig options for each and every of these new files,
> but that's not a sustainable model.
> The patch provides a way for each Makefile.inc to add such files by setting up a
> couple of variables:
> # -y can, as usual be used for conditional inclusion
> cbfs-files-y += filename
> filename-name := CBFS filename
> filename-type := CBFS type
> filename-position := location in CBFS (eg. 0xfff80000)
> filename can either be a filename in the current directory (or a relative path
> from there) or, if that doesn't match a file, a path starting from the tree
> filename in filename-name etc. means the actual filename, for example:
> cbfs-files-y += mbi.bin
> mbi.bin-name := mbi.bin
> mbi.bin-type := 0x80
How does that work with specifying those filenames in Kconfig? Would we
cbfs-files-y += $(CONFIG_MBI_FILE)
or some such?
Or should we go away from that and just require people to put the right
files in place with the right file names?
More information about the coreboot