[coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

Keith Hui buurin at gmail.com
Tue Dec 21 04:53:13 CET 2010


As promised. Attached is my fix:

Fully convert 440BX RAM init debugging to use printk(). Fixes build
breakage with CONFIG_DEBUG_RAM_SETUP enabled.

A number of debugging messages have been tweaked to take advantage of
the "new found" ability to output decimal numbers. :-D

I also need to make a small change to the dimm_size struct to fix
another breakage.

Build tested with the modified abuild I used to report this bug. Boot
tested on P2B-LS.

Joseph, now go fix i810. ;-)

Happy holidays
Keith

Signed-off-by: Keith Hui <buurin at gmail.com>

On Mon, Dec 20, 2010 at 11:12 AM, Joseph Smith <joe at settoplinux.org> wrote:
>
>
> On Sun, 19 Dec 2010 21:56:58 -0500, Keith Hui <buurin at gmail.com> wrote:
>> As title. Log from a locally modified abuild attached.
>>
>> I think this is something we did some time ago with simplifying
>> debugging facility - trying to use printk() everywhere.
>>
> Well, that is not good. Not good at all...
>
> --
> Thanks,
> Joseph Smith
> Set-Top-Linux
> www.settoplinux.org
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 440bx.config-debug-ram-setup.patch
Type: application/octet-stream
Size: 5583 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101220/291ce6d5/attachment.obj>


More information about the coreboot mailing list