[coreboot] [PATCH] CONFIG_DEBUG_RAM_SETUP breaks build on i82810, i440bx and maybe more

Keith Hui buurin at gmail.com
Wed Dec 22 05:01:23 CET 2010


On Tue, Dec 21, 2010 at 8:53 AM, Idwer Vollering <vidwer at gmail.com> wrote:
> 2010/12/21 Keith Hui <buurin at gmail.com>:
>> As promised. Attached is my fix:
>
> Copy/paste:
>
*snip*
>> Index: src/northbridge/intel/i440bx/debug.c
>> ===================================================================
>> --- src/northbridge/intel/i440bx/debug.c (revision 6205)
>> +++ src/northbridge/intel/i440bx/debug.c (working copy)
>> ...
>> - print_debug("dimm: ");
>> - print_debug_hex8(i);
>> - print_debug(".0: ");
>> - print_debug_hex8(device);
>> + printk(BIOS_DEBUG, "dimm: %d", i);
>> + printk(BIOS_DEBUG, ".0: %02x", device);
>
> dimm --> DIMM:
> +printk(BIOS_DEBUG, "DIMM: %d.0: %02x", i, device);
>

Thanks. Updated in attached.
I don't know what the .0 is here for so I took it out as well. Also
gone is a second version of dump_spd_registers() that is #if'd out,
and not too different from what's currently used.

Signed-off-by: Keith Hui <buurin at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 440bx.config-debug-ram-setup.patch
Type: application/octet-stream
Size: 5552 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101221/bd3cabb6/attachment.obj>


More information about the coreboot mailing list