[coreboot] Patch for getpir when using input image file

Marc Bertens mbertens at xs4all.nl
Tue Dec 28 11:47:16 CET 2010

Sorry, i attached the patch file.

Reading the coreboot_ram file in the build direcory gives you the check
if the checksum of the table you build has a correct checksum. i added
this functionally about 6 months ago, but found a problem when searching
a file image for the $PIR prefix.


-----Original Message-----
From: Stefan Reinauer <stepan at openbios.org>
To: coreboot at coreboot.org
Subject: Re: [coreboot] Patch for getpir when using input image file
Date: Tue, 28 Dec 2010 10:38:21 +0100

On 12/27/10 7:45 PM, Marc Bertens wrote: 

> Signed-off: Marc Bertens <mbertens at xs4all.nl>
> There was a problem when using the getpir utility with the
> coreboot_ram file, basically removed the loop around the search
> function, in the coreboot_ram image the start $PIR is not on a 16 byte
> boundary. due to the search already was matching 6 bytes of the start
> of the table (including the version of the table), this was not
> necessary any more.  

There was no patch attached

The copy in the coreboot_ram image is not the one the tool should find,
usually it should even be compressed and thus not found at all. Instead
coreboot_ram will copy a PIR table to ram and that copy is the one the
tool is/should be looking for.


coreboot mailing list: coreboot at coreboot.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101228/27e82e32/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff.getpir.2010-12-27.patch
Type: text/x-patch
Size: 7425 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101228/27e82e32/attachment.patch>

More information about the coreboot mailing list