[coreboot] [PATCH 7/7] Geode GX2 cleanup next round

Nils njacobs8 at hetnet.nl
Thu Dec 30 00:42:30 CET 2010


Hi Myles,
Thanks for  reviewing and committing my patches.

Op woensdag 29 december 2010 21:42:39 schreef u:
> On Wed, Dec 29, 2010 at 12:05 PM, Nils <njacobs8 at hetnet.nl> wrote:
> > Move hardcoded IRQ defining from northbridge.c to irq_tables.c .
> 
> There's also an added init function for the WYSE board.  Did you mean
> to add it?  It looks like it's only printing.

Yes i forgot to state it in the commit message, sorry.
I added it because almost all Geode boards had it in Mainboard.c .
Is it useless?
Should i make a patch to remove this code from all boards?

Thanks, Nils.




More information about the coreboot mailing list