[coreboot] [PATCH] Math support for libpayload

Patrick Georgi patrick at georgi-clan.de
Sun Feb 7 21:02:19 CET 2010

Am 07.02.2010 20:56, schrieb Stefan Reinauer:
> It increases code size of libpayload roughly by a factor of five..
> That's an incredible amount of code.

> The code is unfortunately not quite clean and not really adapted to
> libpayload either. In fact, it looks like the BSD sources have mostly
> been just untarred in the libpayload directory.
> A few checks show
Thanks for doing these.

> - the includes introduce many new and undocumented preprocessor flags,
> like __BSD_VISIBLE and __XPG_VISIBLE that might
Various degrees of standard compliance. Not sure if we need it.

> - mc68881 assembler versions of math functions?!?
libpayload for palm pilot? *ducks*

> - rcsids?
If we take code from a BSD wholesale, these are sensible to track
upstream. That's how they do it among each other, so we can expect those
ids to be correct.

> Roughly I think that this approach of adding code to libpayload is not
> preferrable. It would be much nicer to see that those functions used by
> tinyscheme are chosen carefully, be added to libpayload in minimal
> implementations and commented in the same style we commented all the
> rest of libpayload.
Just to avoid any misunderstanding here: Code can still be imported from
other sources, but not as a simple cp -R job.


More information about the coreboot mailing list