[coreboot] [commit] r5097 - in trunk/src: mainboard/amd/norwich mainboard/olpc/btest mainboard/olpc/rev_a southbridge/amd/cs5536

Peter Stuge peter at stuge.se
Tue Feb 9 11:40:28 CET 2010


repository service wrote:
> +++ trunk/src/mainboard/amd/norwich/romstage.c	Tue Feb  9 11:22:33 2010	(r5097)
..
> -	cs5536_setup_onchipuart();
> +	cs5536_setup_onchipuart(1);

> +++ trunk/src/southbridge/amd/cs5536/cs5536_early_setup.c	Tue Feb  9 11:22:33 2010	(r5097)
..
> +void cs5536_setup_onchipuart(int uart)
> +{
> +	switch (uart) {
> +	case 1:
> +		cs5536_setup_onchipuart1();
> +		break;
> +	case 2:
> +		cs5536_setup_onchipuart2();
> +		break;
> +	}
> +}

If you have an opportunity to revisit this then I think it would be
nicer to just remove this extra function and call the actual setup
functions directly.


//Peter




More information about the coreboot mailing list