[coreboot] [PATCH] (somewhat) clean up intel southbridge drivers
rminnich at gmail.com
Mon Feb 22 17:14:28 CET 2010
On Mon, Feb 22, 2010 at 6:57 AM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> My main worry with this kind of stuff is that we get a certain degree of
> code duplication. As you correctly noted some of that just _looks_
> duplicated as the i82801xx driver is incomplete. But there's also stuff
> which _is_ generic for most ICHs. Maybe we can later factor out some of
> that to some ichlib.c or something like that. For example the code in
> i82801*_early_smbus.c is likely a good candidate (didn't check the
> datasheets closely yet, though).
How many of these parts are still made? And, how many of them have
started to diverge from data sheets? I worry about the case that
somebody changes ichlib.c for one part and it breaks another. I think
this is one case where code duplication is a good thing.
More information about the coreboot