[coreboot] [PATCH] fix clobbers in the K8 CAR

ron minnich rminnich at gmail.com
Mon Feb 22 17:31:50 CET 2010


2010/2/21 Rudolf Marek <r.marek at assembler.cz>:

> This patch adds clobber regs into the play as assembly trashes random registers.
> I was bitten by this while doing MSR I/O because ECX got corrupted. I attempted
> to create nice barrier for GCC while changing the stack location too.

The complex ways in which we have to convince gcc to do __asm__
correctly make me wonder if we shouldn't start
putting assembly into assembly into .s files, not .c files. If we have
this much trouble with __asm__, how much are we really
gaining when we use it? Why not just set up a .s?

ron




More information about the coreboot mailing list