[coreboot] [PATCH] cbfs, smaller api, more types

Peter Stuge peter at stuge.se
Sat Feb 27 14:57:40 CET 2010

Stefan Reinauer wrote:
> - make some functions static because they're only used within cbfs.c
> - drop unused cbfs_get_file()

Great. These hunks are

Acked-by: Peter Stuge <peter at stuge.se>

> - add new types for bootsplash, RAW, VSA, MBI

Um..? Oh, ok, they aren't all bootsplash types. But, I think there
should be just one meaningful parameter for each file. My point is
that a bootsplash type is redundant, since a specific filename must
already be used for bootsplashes. The same is true for VSA.

What is MBI?

How could this be handled better? Maybe we should change things
around so that the filename is insignificant, and make the type more
important? That makes user error much less obvious however, the
filename concept is already well known by everyone.

Do we need so specific types at all?


More information about the coreboot mailing list