[coreboot] a bit more user friendly cbfstool print
patrick at georgi-clan.de
Wed Jan 6 19:02:18 CET 2010
Am 06.01.2010 17:20, schrieb Maciej Pijanka:
> I know that all experienced corebooters knew well that null mean empty space
> but that was't obvious for me when i tried first time compile coreboot.
> Patch in attachment.
> Signed-off by: Maciej Pijanka <maciej.pijanka at gmail.com>
+ if (strlen(fname) == 0)
+ printf("%-30s 0x%-8x %-12s %d\n", "(empty)",
+ current - phys_start, strfiletype(ntohl(thisfile->type)),
printf("%-30s 0x%-8x %-12s %d\n",
(const char *)(phys_to_virt(current) +
I don't quite like the duplication that's going on here.. how about
> if (strlen(fname) == 0) fname = "(empty)";
> printf("...", fname, ...);
That way, when we feel the need to change that string, we only have to change it once.
More information about the coreboot