[coreboot] [PATCHes] mostly Kbuild fixes for out of tree build, Kconfig support in abuild
mylesgw at gmail.com
Fri Jan 29 21:34:41 CET 2010
On Fri, Jan 29, 2010 at 1:22 PM, Stefan Reinauer <stepan at coresystems.de>wrote:
> On 1/29/10 9:16 PM, Myles Watson wrote:
> > * don't turn on WARNINGS_AS_ERRORS for Qemu per default
> I disagree with this change. I think it should be noticed when changes add
> warnings to a target that is free of them. I think the goal should be to be
> able to turn this on for all targets. There have been several times that
> warnings pointed out breakage. Ignoring them seems counterproductive.
> Hm... It did not compile without warnings for me when I tried, so that's
> why I disabled it at some point.
It happens frequently, but the kbuildall report from 5063 says it built, and
5064 works for me. Hopefully tracking it will make it happen less often.
Each port that gets to the "warnings free" point will cover more and more of
the code base.
> I generally agree with what you're saying. Actually I manually deleted
> the "add -Werror-implicit-function-declaration to CFLAGS" part of my patch
> because I figured people would feel no love for me if I left it in. I think
> it should go in then, too.
I guess that depends on how many boards it breaks and how long it would take
us to fix them.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot